BUG: DataFrame.explode is failing on scalar int value. #43324
Conversation
The **int** datatype of the column was raising this issue.
| @@ -8271,7 +8271,7 @@ def explode( | |||
|
|
|||
| columns: list[str | tuple] | |||
| if is_scalar(column) or isinstance(column, tuple): | |||
| assert isinstance(column, (str, tuple)) | |||
| assert isinstance(column, (str, tuple, int)) | |||
There was a problem hiding this comment.
Add tests first
We should check for scalar values
There was a problem hiding this comment.
actually i would remove the assert entirely i think (but agreed on tests), e.g. you can in theory have a datetime here as well
There was a problem hiding this comment.
Yes hence the scalar idea, but yeah removing is ok too
jreback
changed the title
simonjayhawkins
added
the
Regression
|
@shubh242 can you aslo add a whatsnew note in 1.3.3, put in the bug fix reshaping section is ok |
@shubh242 in the 1.3.x release notes we don't have the subsections. so just add to the regressions section. |
|
@shubh242 are you interested in continuing? |
Yes i would like to give it another try. Can you be specific about what is failing by doing the change. |
|
Please adress the review comments above |
|
@shubh242 this PR is not yet ready (needs release note and tests) and planning a release tomorrow, moving to 1.3.4 milestone. |
|
@shubh242 if you can update to comments and merge master |
|
superseded by #43802 |
closes #43314
The int datatype of the column was raising this issue.